Implemented: support to add,update and display an address and latitude, longitude for a facility (#20) #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when no address found (hotwax#20)
ymaheshwari1
requested changes
Nov 21, 2023
| </ion-item> | ||
| </ion-content> | ||
|
|
||
| <ion-fab @click="saveAddress" vertical="bottom" horizontal="end" slot="fixed"> |
There was a problem hiding this comment.
Move click event to ion-fab-button
| } | ||
| }, | ||
| getGeoPoint(state) { | ||
| return state.current?.geoPoint ? JSON.parse(JSON.stringify(state.current.geoPoint)) : {} |
There was a problem hiding this comment.
Why we have used optional chaining here?
| entityName: "FacilityContactDetailByPurpose", | ||
| orderBy: 'fromDate DESC', | ||
| filterByDate: 'Y', | ||
| fieldList: ['address1', 'address2', 'city', 'contactMechId', 'countryGeoName', 'latitude', 'longitude', 'postalCode', 'stateGeoName'] |
There was a problem hiding this comment.
Pass viewSize as 1, as we only need a single record from this entity.
| throw resp.data | ||
| } | ||
| } catch(err) { | ||
| logger.error(err) |
There was a problem hiding this comment.
Suggested change
| logger.error(err) | |
| logger.error('Failed to fetch the postal address for the facility', err) |
alsoK2maan
suggested changes
Nov 23, 2023
src/store/modules/util/index.ts
Outdated
| locationTypes: {} | ||
| locationTypes: {}, | ||
| countries: [], | ||
| states: [] |
There was a problem hiding this comment.
Suggested change
| states: [] | |
| states: {} |
src/store/modules/util/UtilState.ts
Outdated
| @@ -2,4 +2,6 @@ export default interface UtilState { | |||
| productStores: any[]; | |||
| facilityTypes: object; | |||
| locationTypes: object; | |||
| countries: any[]; | |||
| states: any[]; | |||
There was a problem hiding this comment.
Suggested change
| states: any[]; | |
| states: any; |
| <ion-item @keyup.enter.stop> | ||
| <ion-label>{{ translate("State") }}</ion-label> | ||
| <ion-select interface="popover" :placeholder="translate('Select')" v-model="address.stateGeoId"> | ||
| <ion-select-option v-for="(state, index) in states[address.countryGeoId]" :key="index" :value="state.geoId">{{ state.geoName }}</ion-select-option> |
There was a problem hiding this comment.
Suggested change
| <ion-select-option v-for="(state, index) in states[address.countryGeoId]" :key="index" :value="state.geoId">{{ state.geoName }}</ion-select-option> | |
| <ion-select-option v-for="state in states[address.countryGeoId]" :key="state.geoId" :value="state.geoId">{{ state.geoName }}</ion-select-option> |
Make same changes for country ion-select.
alsoK2maan
suggested changes
Nov 23, 2023
Comment on lines
129
to
137
| const payload = { | ||
| address1: this.address.address1, | ||
| address2: this.address.address2, | ||
| city: this.address.city, | ||
| countryGeoId: this.address.countryGeoId, | ||
| facilityId: this.facilityId, | ||
| postalCode: this.address.postalCode, | ||
| stateProvinceGeoId: this.address.stateGeoId | ||
| } |
There was a problem hiding this comment.
Suggested change
| const payload = { | |
| address1: this.address.address1, | |
| address2: this.address.address2, | |
| city: this.address.city, | |
| countryGeoId: this.address.countryGeoId, | |
| facilityId: this.facilityId, | |
| postalCode: this.address.postalCode, | |
| stateProvinceGeoId: this.address.stateGeoId | |
| } | |
| const payload = { | |
| ...this.address, | |
| facilityId: this.facilityId | |
| } |
| <ion-content> | ||
| <form @keyup.enter="saveGeoPoint"> | ||
| <ion-item class="ion-margin-bottom"> | ||
| <ion-input placeholder="Zipcode" v-model="geoPoint.postalCode" /> |
| closeModal() { | ||
| modalController.dismiss() | ||
| }, | ||
| async saveAddress() { |
There was a problem hiding this comment.
Only call saveAddress if there are changes in the address
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #20
Short Description and Why It's Useful
Implemented support to add, update and display an address and latitude, longitude for a facility.
Screenshots of Visual Changes before/after (If There Are Any)
Contribution and Currently Important Rules Acceptance